On Thursday 19 June 2003 11:42, cmpilato@collab.net wrote:
> Christian Daudt <csd_ob@daudt.org> writes:
> > But the fact is that, regardless of the problem that caused the code
> > to call stringbuf_set with null (which remains to be fixed) ,
> > svn_stringbuf_set shouldn't coredump because it received a value it
> > doesn't like.
>
> On the contrary, we specifically allow that function to segfault on
> bad input because it helps us to find *real* bugs in the code. If we
> simply papered over the problem, we'd have a much harder time tracking
> down, for example, the bug you're seeing. And for what gain?
>
So someone else doesn't spend a morning trying to figure why they're getting
coredumps all of the sudden...
Here is an alternative patch.
csd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 19 22:21:53 2003