[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

core dump with svn r6178

From: Christian Daudt <csd_ob_at_daudt.org>
Date: 2003-06-19 18:56:34 CEST

 I'm starting to roll out subversion for a number of people in my group and
I've run into many of them getting coredumps on checkouts (of course I never
got one...). Anyways, I've tracked it down to parsing this piece of xml being
received: <S:open-directory rev=\"-1\">
 And with that, start_element in fetch.c (in libsvn_ra_dav) is running this
piece of code:
          name = get_attr(atts, "name");
          /* ### verify we got it. punt on error. */
          svn_stringbuf_set(rb->namestr, name);

Since there is no "name" attribute, name (the variable) gets set to null and
svn_stringbuf_set is being called with its value param == null which it is
not set up to handle. The attached patch should fix the coredump (by
protecting svn_stringbuf_set) but I'm only addressing the consequence, not
the cause. I don't know the protocol to know whether that xml snippet is
wrong, or if it is valid and the handler isn't handling it properly so I'll
defer that part to someone that has a clue of what's going there.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Jun 19 18:58:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.