On Thu, Jun 19, 2003 at 10:00:57AM +1000, leif.eriksen@hpa.com.au wrote:
> So perhaps the original patch was OK, as c89 doesn't work on my GCC 2.96 on
> RH7.1, and the patch specifically tested this.
>
> Perhaps it would be easiest if a test was added to the configure.in that
> test whether the -std=c89 on the platform in question works - much like the
> testing for finding the Berkeley DB headers and libraries - it actually
> tries to compile a code snippet, and checks the return code of the compile
> and the execution of the resulting binary.
That'd be awesome, but I don't personally have the time to write such a
configure test.
If someone were to remove the std=c89 stuff now, I won't complain again :)
>
> Or we could add a note to the INSTALL file that a compiler that supports
> -std=c89 is required and a tip to edit the CFLAGS in the resulting Makefile
> if it causes an issue.
That's not really an acceptable solution.
>
> Leif Eriksen
> Developer
> HPA - IT Development
> +61 3 9217 5545
> leif.eriksen@hpa.com.au
>
> -----Original Message-----
> From: Michael Price [mailto:michael.price@computer.org]
> Sent: Thursday, June 19, 2003 1:48 AM
> To: Kevin Pilch-Bisson; Michael Price
> Cc: Sander Striker; Justin Erenkrantz; Leif Eriksen;
> dev@subversion.tigris.org
> Subject: Re: [PATCH] -std-c89 not supported
>
>
> --- Kevin Pilch-Bisson <kevin@pilchie.homeip.net> wrote:
> > On Wed, Jun 18, 2003 at 08:40:09AM -0700, Michael Price wrote:
> > > --- Kevin Pilch-Bisson <kevin@pilchie.homeip.net> wrote:
> > > If there is a test if should be based on the compiler not the OS.
> >
> > It also depends on the system header files used by the compiler.
> >
> > Perhaps with your version of solaris it works fine, but with some
> > other ones,
> > it doesn't.
> >
> > Feel free to add your version of solaris to the list of platforms
> > where it is
> > enabled.
>
> Feel free to demonstrate any platform where gcc 3.3 compiles and is
> installed properly and the option doesn't work.
>
> :)
>
> Michael
>
>
>
> **********************************************************************
> IMPORTANT
> The contents of this e-mail and its attachments are confidential and intended
> solely for the use of the individual or entity to whom they are
> addressed. If you received this e-mail in error, please notify
> the HPA Postmaster, postmaster@hpa.com.au, then delete
> the e-mail.
>
> This footnote also confirms that this e-mail message has been swept for
> the presence of computer viruses by MimeSweeper. Before opening or
> using any attachments, check them for viruses and defects.
>
> Our liability is limited to resupplying any affected attachments.
>
> HPA collects personal information to provide and market our services.
> For more information about use, disclosure and access see our Privacy
> Policy at www.hpa.com.au
> **********************************************************************
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 19 02:05:08 2003