Re: (resend) [rfc/patch] : #933,#735 import syntax, mkdir -p

David Kimdon <dwhedon@debian.org> writes:

> Super, here is a revised patch, testsuite run over file: and svn:
> access methods.

I made a couple of tweaks (stuff I missed in my last review), and now
I'm testing the result. The tweaks were really simple: in the
do/while() loop for opening the RA session, we needed to call
svn_error_clear() on non-fatal errors. And then there were some
places where you didn't follow the space-before-paren coding style
(where what should have been 'fn_call (param)' was 'fn_call(param)').
Not really big deals to fix.

Okay, testing looks pretty good. Now, after having used the feature,
I have the following complaints:

   - I'm not really fond of the fact that there is no notification
     regarding the intermediate directories. Sucker just sits there
     (especially long over ra_dav ... like everything else over
     ra_dav) appearing to do nothing. I dunno the fix for this,
     though, because we don't want the notifications for intermediate
     dirs to appear as though they were on-disk.

   - The generated log message also doesn't show the creation of the
     intermediate directories. Not fond of this, either, but again,
     the solution evades me.

   - We need to be calling the cancel_func() during the do/while()
     loop in case the user has had a change of heart.

I'll take care of the cancel_func() thing, and will go ahead and
commit this all up if it passes testing. Thanks for the work, David.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 18 18:49:06 2003