[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Scalability problem using svn_load_dirs.pl during

From: Robert Pluim <rpluim_at_bigfoot.com>
Date: 2003-06-18 15:25:02 CEST

Mats Nilsson writes:
> Yes!
> Svn stays at about 6M (instead of hitting the wall at 600M).
> Thanks!

Cool. Could someone with commit privileges check my patch? (I've
reattached it with a log message).

> Next problem when it gets down to "svn commit", which also eats all my
> memory (a little slower than svn rm, though).

I see the client memory usage growing here when I commit a mass
deletion, but it's not that excessive, ~40M for 1000 file delete. How
bad is it for you?

> Is that related to issue 860 (httpd memory use proportional to file
> size)?

Doesn't look like it at first glance (but you're running over file://,


* svn/subversion/libsvn_client/delete.c (svn_client_delete): Actually
  use the subpool that we were already creating.

Index: subversion/libsvn_client/delete.c
--- subversion/libsvn_client/delete.c (revision 6274)
+++ subversion/libsvn_client/delete.c (working copy)
@@ -274,15 +274,15 @@
           svn_wc_adm_access_t *adm_access;
           const char *path = APR_ARRAY_IDX (paths, i, const char *);
- const char *parent_path = svn_path_dirname (path, pool);
+ const char *parent_path;
           svn_pool_clear (subpool);
+ parent_path = svn_path_dirname (path, subpool);
           /* Let the working copy library handle the PATH. */
           SVN_ERR (svn_wc_adm_open (&adm_access, NULL, parent_path,
- TRUE, FALSE, pool));
+ TRUE, FALSE, subpool));
           SVN_ERR (svn_client__wc_delete (path, adm_access, force,
- FALSE, ctx, pool));
+ FALSE, ctx, subpool));
           SVN_ERR (svn_wc_adm_close (adm_access));
           /* See if the user wants us to stop. */

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 18 15:20:40 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.