Mats Nilsson writes:
> Hi.
>
> I tried to use svn_load_dirs to archive some external stuff that we use.
> Sadly svn ran out of memory in the process.
>
> Granted, the machine that I use is not particularly powerful, and I've
> seen many accounts on this list of more able machines running into the
> wall.
>
> When it processes the second version of the external library, it quite
> quickly goes through the harvesting of information, and the first call
> to svn:
> svn add -N --targets ....
> But when it calls the next command (svn rm --targets ...), the svn grows
> until all memory and swap is exhausted
My-oh-my, svn_client_delete creates a subpool, and then never uses
it. Mats, does the following patch help?
Robert
Index: subversion/libsvn_client/delete.c
===================================================================
--- subversion/libsvn_client/delete.c (revision 6274)
+++ subversion/libsvn_client/delete.c (working copy)
@@ -274,15 +274,15 @@
{
svn_wc_adm_access_t *adm_access;
const char *path = APR_ARRAY_IDX (paths, i, const char *);
- const char *parent_path = svn_path_dirname (path, pool);
+ const char *parent_path;
svn_pool_clear (subpool);
-
+ parent_path = svn_path_dirname (path, subpool);
/* Let the working copy library handle the PATH. */
SVN_ERR (svn_wc_adm_open (&adm_access, NULL, parent_path,
- TRUE, FALSE, pool));
+ TRUE, FALSE, subpool));
SVN_ERR (svn_client__wc_delete (path, adm_access, force,
- FALSE, ctx, pool));
+ FALSE, ctx, subpool));
SVN_ERR (svn_wc_adm_close (adm_access));
/* See if the user wants us to stop. */
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 18 14:06:34 2003