[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Purify report for fs-test

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2003-06-17 22:22:54 CEST

Philip Martin wrote:

>Branko ├ä┼ĺibej <brane@xbc.nu> writes:
>
>
>
>>Right, here's the list of problems found by Purify when running fs-test:
>>
>>[W] UMR: Uninitialized memory read in svn_fs__bdb_open_uuids_table
>> Reading 1 byte from 0x0013f091 (1 byte at 0x0013f091 uninitialized)
>> Address 0x0013f091 points into a thread's stack
>> Thread ID: 0x4a0
>> Error location
>> svn_fs__bdb_open_uuids_table [uuids-table.c:78]
>> value.size = sizeof (buffer) - 1;
>>
>> apr_uuid_get (&uuid);
>> => apr_uuid_format (buffer, &uuid);
>>
>>
>
>valgrind on Linux doesn't report anything here. How does 0x0013f091
>compare to buffer and &uuid? I note that APR's Windows UUID
>implementation is completely different from the Unix one, could the
>error be in inside apr_uuid_format?
>
That's quite possible, yes.

> It's hard to see what could be
>wrong with the line that calls apr_uuid_format.
>
Neither can I. Most probably an off-by-1 error in APR; but I'll
investigate when I get the time.

>
>
>
>> BDB_ERR (uuids->put (uuids, 0, &key, &value,
>> DB_APPEND | SVN_BDB_AUTO_COMMIT));
>> svn_fs_create_berkeley [fs.c:520]
>> svn_test__create_fs [fs-helpers.c:97]
>> reopen_trivial_transaction [fs-test.c:232]
>> do_test_num [svn_tests_main.c:153]
>> main [svn_tests_main.c:289]
>> mainCRTStartup [crtexe.obj]
>>
>>
>
>
>

-- 
Brane ─îibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 17 22:23:45 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.