[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug: Useless error message when SVN_SSH points to non-existent file

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-06-07 02:49:01 CEST

On Friday, June 6, 2003, at 05:47 PM, Eric Hanchrow wrote:

>
> This is svn 0.23.0 on Cygwin, configured with
> "--prefix=/usr/local/stow/svn-0.23.0"
>
> Since this is a client-only installation, I don't have Berkeley DB
> installed.
>
> Here's an example of subversion working happily:
>
> $ svn ls
> svn+ssh://offby1.atm01.sea.blarg.net/home/offby1/svn-repos/trunk/
> config-files
>
> When I run this, I see, as I expect, a list of the files in my
> `config-files' directory on the repository.
>
> (Of course if *you* try exactly the above, it'll fail because you
> can't log in to that machine. But you get the point.)
>
> Now here's how to reproduce the problem that I'm whining about:
>
> $ SVN_SSH=garbage svn ls
> svn+ssh://offby1.atm01.sea.blarg.net/home/offby1/svn-repos/trunk/
> config-files
>
> In this case, instead of seeing an error message to the effect of "I
> can't run the SSH program `garbage' because command not found", I see
>
> svn: Network connection closed unexpectedly
> svn: Connection closed unexpectedly
>
> This actually bit me -- I had set SVN_SSH in my environment while
> playing with some Win32 subversion clients, and then forgot that it
> was there. Afterwards, every time I tried to run the Cygwin
> subversion, I got the above cryptic message, and had to scratch my
> head for a long time before I figured out what was wrong.

Unfortunately, it seems that fixing this will require changes to APR.
We can use apr_procattr_error_check_set to make apr_proc_create try to
verify that what we're executing exists and is readable/executable, but
that will currently only work if you're using APR_PROGRAM or
APR_PROGRAM_ENV, or if the first character of the program is a /. In
all other cases, there's a todo comment about searching PATH for the
program, but currently it isn't done. We're using APR_PROGRAM_PATH,
and the SVN_SSH probably won't be an absolute path, so that won't work
for us at the moment.

Anyone feel like writing some APR code?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 7 02:49:42 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.