Re: svn commit: rev 6161 - trunk/subversion/libsvn_fs

Glenn A. Thompson wrote:

>
>
> Branko Čibej wrote:
>
>> joe@tigris.org wrote:
>>
>>
>>
>>> Author: joe
>>> Date: Thu Jun 5 16:54:46 2003
>>> New Revision: 6161
>>>
>>> Modified:
>>> trunk/subversion/libsvn_fs/trail.c
>>> Log:
>>> Fix for occasional unhandled deadlock errors, as seen, for example,
>>> in: http://www.contactor.se/~dast/svn/archive-2003-03/0152.shtml
>>>
>>> * subversion/libsvn_fs/trail.c (svn_fs__retry_txn): Check the whole
>>> stack for a deadlock error.
>>>
>>>
>>
>> I wonder, shouldn't we just try to figure out where we're wrapping the
>> deadlock errors? I mean, it doesn't make any sense to wrap them if we
>> know that a deadlock must always result in a retry. It seems to me that
>> this change is just hiding existing error handling bugs.
>>
>>
>>
> Cool Karl, now you can defer to Brane on this:-)
>
> Brane did you look at the "[PATCH] deadlock fix?" thread?

I did -- afterwards. :-(
It doesn't change my opnion, though.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org