Re: [PATCH] deadlock fix?

Joe Orton <jorton@redhat.com> writes:
> I'm not auditing for it - checking the whole stack in retry_txn seemed
> good enough to me, since it's not going to be a performance hit when
> there is no error or anything. I'm not sure whether special-casing the
> error handling in a bunch of places would be a good thing anyway, I
> don't know this code at all.

Oh, it wasn't an issue of performance for me either, rather of
cleanliness/comprehensibility.

But the more I think about your solution, the better it seems. I
guess there's really no way a DB_DEADLOCK could end up in the error
stack except through a bdb deadlock actually happening. I suppose to
be really paranoid, we could make sure that it is the last error on
the stack, but whatever.

I withdraw my objection :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 5 22:19:28 2003