I already have filed this as issue #1337 (and included a patch)
Marc
-----Original Message-----
From: Sander Roobol [mailto:phy@wanadoo.nl]
Sent: Wednesday, June 04, 2003 10:34 AM
To: Marc Haesen
Cc: dev@subversion.tigris.org
Subject: Re: Bug with store-password?
Filed as issue #1346.
Sander
On Tue, May 27, 2003 at 04:48:42PM +0200, Marc Haesen wrote:
> Hi,
>
> When I add the statement 'store-password=yes' in my config file, my
password
> is not cached. If I remove this line from the config file, my password is
> cached.
> I am using the svn.exe client.
>
> If I look at line 1034 of subversion\clients\cmdline\main.c I see the
> following code:
>
> /* There are two different ways the user can disable disk caching
> of credentials: either via --no-auth-cache, or in the config
> file ('store-password = no'). */
> svn_config_get (cfg, &store_password_val,
> SVN_CONFIG_SECTION_AUTH,
> SVN_CONFIG_OPTION_STORE_PASSWORD,
> NULL);
> if (opt_state.no_auth_cache || store_password_val)
> svn_auth_set_parameter(ab, SVN_AUTH_PARAM_NO_AUTH_CACHE,
> (void *) "");
>
> Does this code not have to be:
>
> /* There are two different ways the user can disable disk caching
> of credentials: either via --no-auth-cache, or in the config
> file ('store-password = no'). */
> svn_config_get (cfg, &store_password_val,
> SVN_CONFIG_SECTION_AUTH,
> SVN_CONFIG_OPTION_STORE_PASSWORD,
> NULL);
> if (opt_state.no_auth_cache || (store_password_val &&
> !strncmp(store_password_val,"no")))
> svn_auth_set_parameter(ab, SVN_AUTH_PARAM_NO_AUTH_CACHE,
> (void *) "");
>
> I am assuming that storing of the password is the default behaviour.
>
> Marc
> Hi,
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 4 11:17:35 2003