Re: URL encoding/decoding (was: svn ls shows escaped paths)

On Mon, 2003-06-02 at 23:23, Greg Stein wrote:
> On Mon, Jun 02, 2003 at 08:11:33AM -0500, cmpilato@collab.net wrote:
> >...
> > I think Greg H. knows what you're talking about.

That wasn't a great assumption, but I think I've caught up.

> Hunh. Mike pointed out that ra_local decodes the URL pretty early. I just
> looked at ra_svn, and it ships the encoded URL over to the server, which
> then decodes it [to look for the repos].

If we were doing things properly, we would never URI-decode a URL; that
operation doesn't really make sense. You're supposed to decode after
you've split the URL into scheme and scheme-specific part, and (if
appropriate) into all the other subparts like hostname and path.

I played with doing things properly in ra_svn, but found that it got
irritating to deal with copyfrom history. So I went back to doing it
the broken way ra_local does it.

The brokenness doesn't actually hurt us, because none of the separator
characters should appear in any of the parts we care about (we have no
schemes containing ":" characters, hostnames cannot contain "/"
characters, and we don't use usernames and passwords encoded into
URIs.). It's just conceptually unclear.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 3 05:45:31 2003