Re: svn commit: rev 6120 - in trunk/subversion: bindings/swig include libsvn_delta libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_wc mod_dav_svn

On Mon, Jun 02, 2003 at 04:47:01PM -0500, ghudson@tigris.org wrote:
>...
> * bindings/swigutil_py.c
> (thunk_apply_textdelta): A NULL handler is no longer allowed.

Unfortunately, there is a lot of code which returns None from the
apply_textdelta call, which will now break. Also, there isn't an easy way
for Python to say "give me the noop handler". If Python has to implement its
own noop handler, and deal with the thunking back and forth... oof.

So... I'm testing out a fix that reverts this change, and will return the
noop handler if the Python code returns None.

>...
> +++ trunk/subversion/bindings/swig/swigutil_py.c Mon Jun 2 16:46:58 2003
> @@ -736,24 +736,15 @@
> goto finished;
> }
>
> - if (result == Py_None)
> - {
> - Py_DECREF(result);
> - *handler = NULL;
> - *h_baton = NULL;
> - }
> - else
> - {
> - handler_baton *hb = apr_palloc(ib->pool, sizeof(*hb));
> + handler_baton *hb = apr_palloc(ib->pool, sizeof(*hb));

Moving this variable declaration out of the block scope also resulted in a
syntax error... fixing :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org