[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6110 - trunk/subversion/svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-06-02 19:06:07 CEST

On Mon, 2003-06-02 at 12:56, Philip Martin wrote:
> Being able to run multi-threaded svnserve on Unix is the reason I
> wrote the patch!

Okay, the -T option can stay.

But, after hacking on this a bit, I think the level of spaghetti factor
in the current main loop is totally unacceptable. And I think it would
take me too long to unravel it. So I'm going to be unpleasant and
demand that you either:

  * Eliminate the -S and -F options (-F never had any effect) and
refactor the code so that there is a completely independent while() loop
for connection_mode_fork and connection_mode_thread, or

  * Back out your change. It's not maintainable as-is.

It may also be worthwhile to factor out the listen_once mode of
operation into its own little if block before any while loops happen;
that's optional.

If neither APR_HAS_FORK nor APR_HAS_THREADS is defined, the code can
error out or serve one connection at a time, whichever is less code.
There are no platforms we care about with this characteristic, so the
dominating factor is simplicity.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 2 19:07:12 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.