Re: svn commit: rev 6083 - trunk/subversion/libsvn_ra_dav

Greg Stein <gstein@lyra.org> writes:

> On Wed, May 28, 2003 at 01:25:47PM -0500, cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Wed May 28 13:25:45 2003
> > New Revision: 6083
> >
> > Modified:
> > trunk/subversion/libsvn_ra_dav/fetch.c
> > Log:
> > * subversion/libsvn_ra_dav/fetch.c
> > (svn_ra_dav__get_dir): URI-decode the dirent names before using them
> > as hash keys.
>
> -1
>
> (see discussion on the "svn ls shows escaped paths" thread)

Yeah, yeah, I saw (Mr. Cranky Pants...) :-)

You're right, though. We should be maintaining "URL mode" through the
whole interface. So the right fix for the bug seen is to make
ra_local and ra_svn URI-encode those paths, and have the client
URI-decode them when they are about to be displayed. And of course,
change docstrings where necessary to actually explain what's going on
here.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 2 14:57:21 2003