Re: svn ls shows escaped paths

On Mon, Jun 02, 2003 at 01:14:28AM -0400, Greg Hudson wrote:
> On Mon, 2003-06-02 at 01:12, Greg Stein wrote:
> > > * subversion/libsvn_ra_dav/fetch.c
> > > (svn_ra_dav__get_dir): URI-decode the dirent names before using them
> > > as hash keys.
> >
> > I don't think that is correct. URI decoding is a destructive operation. The
> > RA user will not be able to use the returned values for further operation.
> >
> > The URI decoding should happen at the edge of the system. Not down in the
> > middle of it.
>
> Perhaps I'm confused as to what you're suggesting. How far towards the
> edge do you want to push this encoding? If you're not using ra_dav, I
> don't think there's any need to URI-encode dirent names at all.

*de*coding. We already require that incoming URIs are properly encoded.
Thus, there is also the notion that all URIs within the SVN libraries should
be encoded already. Thus, we want to keep things in an encoded state.

The change to __get_dir *decodes* a URI and returns that from a library.
That doesn't make sense. That decoding can also lose information, which
means that the code which is calling RA cannot turn the URI around and use
it with the SVN libraries.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org