[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn ls shows escaped paths

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-06-02 07:12:34 CEST

On Wed, May 28, 2003 at 01:24:30PM -0500, cmpilato@collab.net wrote:
> "SteveKing" <steveking@gmx.ch> writes:
>...
> > svn ls url
> >
> > does not unescape the paths it shows as output.
> > So if a file with e.g. a space is in the repository
> > it isn't shown correctly but with the %20 escape
> > sequence in it.
> >
> > Shouldn't this be changed?
>
> Try this patch:
>
> * subversion/libsvn_ra_dav/fetch.c
> (svn_ra_dav__get_dir): URI-decode the dirent names before using them
> as hash keys.

I don't think that is correct. URI decoding is a destructive operation. The
RA user will not be able to use the returned values for further operation.

The URI decoding should happen at the edge of the system. Not down in the
middle of it.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 2 07:09:36 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.