[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: small user request: confirm before commit

From: Faheem Mitha <faheem_at_email.unc.edu>
Date: 2003-05-27 21:46:54 CEST

On 27 May 2003 14:38:06 -0500, Ben Collins-Sussman <sussman@collab.net> wrote:
> Faheem Mitha <faheem@email.unc.edu> writes:
>> Oh, and please don't reply telling me to "make sure you want to
>> commit" or some such. There is always the possibility of human error.
> If you accidentally commit a change, why not follow-up by committing a
> reverse changeset? That's what the book discusses. We do it in this
> project all the time.

True, this is something that could be done, and is the only option if
you change your mind after committing the change. However, would it
not be better to not commit the change if you realise while you are
writing the log message in the editor (say) that you don't want to
commit? For one thing, doing as you suggest means you have two times
the size of the original change taking up space in the respository,
with a net effect of zero, when it could have been avoided by simply
not committing in the first place.

Let me just ask, what is the downside to my suggestion? As I said
already, this could be made a configurable option, so experts and such
who don't want to bother with it don't have to.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 21:51:47 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.