[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Does dir_delta need a text_deltas parameter?

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-05-27 04:51:57 CEST

Trying to implement this change, I found that delta_files() (a helper
function for dir_delta()) uses the text_deltas flag to save the work of
computing a base checksum. (On the other hand, it does not try to save
the effort of calling svn_fs_contents_changed(), which is supposed to
some day do a full text comparison, but currently doesn't.)

This exposes a flaw in the editor interface: when driving a status
editor, you shouldn't have to go to the work of computing checksums.
But in the absence of out-of-band information, you don't find that out
until you call apply_textdelta(), at which point you've already passed
in the base checksum.

I'm leaving things as-is for now, but this is a pretty serious API wart.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 04:52:53 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.