[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Does dir_delta need a text_deltas parameter?

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-05-26 03:07:40 CEST

libsvn_repos's svn_repos_dir_delta() accepts a text_deltas parameter
which controls whether or not text deltas are generated.

As far as I know, the only reason for this parameter is so that we can
use it for a "status" operation without the overhead of text deltas.

But the parameter is not necessary for this purpose; a status editor
returns a NULL handler from apply_textdelta. So the text_deltas
parameter would appear to be redundant. (And dangerous; if an editor
requests deltas and doesn't get them, or vice versa, than something
is likely to go wrong.)

Does anyone know a reason why I can't nuke it? If nobody can remember
why it's there, I'm sure the test suite will tell me if there's a
real reason for it.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 26 03:08:28 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.