Philip Martin <philip@codematters.co.uk> writes:
> Now when Subversion calls svn_io_file_rename it always expects the
> rename to succeed, perhaps we should use that knowledge and change
> svn_io_file_rename to something like
>
> status = apr_file_rename (...);
> #ifdef SVN_WIN32
> if (status is "Access is denied")
> {
> status = apr_file_rename (...); // immediate retry
> if (status is "Access is denied")
> {
> apr_sleep (...); // or some sort of Windows flush or magic
> SVN_ERR (apr_file_rename (...));
> }
> }
> #endif
>
> We can't really do that in APR since it is, in general, perfectly
> acceptable for apr_file_rename to fail with a permissions problem.
I dunno about all that, now. APR's job is to provide reliable
functionality across all platforms. Certainly that task includes
making up for shortcoming in those areas of operating systems that
have them. I think this is a perfectly reasonable thing to ask of
APR. If, in fact, there is a real permissions problem, the second
rename attempt would be allowed to fail with that error.
You really don't think APR should do this?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 21 16:34:08 2003