SteveKing wrote:
>Branko Cibej wrote:
>
>
>>No, not "if it can't get one from the sytem"; rather, "if the system
>>does not provide one". These cases aren't the same. Hence my proposal to
>>teach APR to detect this case, then change your patch to not report the
>>error _only_ if APR says the system doesn't have that concept, _not_ if
>>APR says it can't retrieve the user ID even if the system _does_ have
>>that concept.
>>
>>
>
>Ah, now I get it. So to fix that case we have to wait for apr to change
>that first? Could last a while...
>
Not if _we_ change APR, right? It should be fairly easy, and you're a
Windows programmer, so I'd naively expect that you could come up with a
patch for APR. :-)
>>>I know you're trying to explain me something but I just don't get it. I
>>>still can't see why my patch (or what I'm trying to do with it) is bad.
>>>
>>>
>>>
>>I don't think what you're trying to do is bad, but your change is too
>>general. It should be narrowed down to just those systems which don't
>>have the concept of a user ID.
>>
>>
>
>But wouldn't that mean to write platform specific code which AFAIK
>subversion tries to avoid?
>
No, it would mean writing platform-specific code in APR. Subversion
would only check status codes returned by APR's functions.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 16 12:13:39 2003