[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: questions about 'bdi' objects in update_editor.c

From: <kfogel_at_collab.net>
Date: 2003-05-15 19:45:17 CEST

Ben Collins-Sussman <sussman@collab.net> writes:
> Before I started making restartable checkout changes (pre-5928),
> maybe_bump_dir_info() would notice when a directory refcount hit zero,
> and do two things: change the directory's revnum from '0' to
> something valid, and install the new_URL.
> In my recent changes (r5928+), add_directory() installs a valid
> revision and URL (inherited directly from the parent) immediately, and
> adds an 'incomplete' flag. I changed maybe_bump_dir_info() to simply
> remove the 'incomplete' flag.
> ... so now the bdi->new_URL value is going completely unused. Same
> with dir_baton->new_URL, as far as I can tell. The fruits of the
> telescoping logic aren't being used anymore.
> Is this situation broken? Am I messing something up here? I would
> have expected 'svn switch' to break, perhaps, since 'new_URL' is no
> longer being installed anywhere... but that's not the case. Maybe
> that post-update crawling code is fixing up the urls for me? (In
> which case, can I just remove all the 'new_URL' stuff everywhere?)
> Can someone shed some light here?

Let's talk about this in person. I don't think anything's broken
here, at least for regular updates -- we install the URL right away
now, so no need for bdi to do it during the refcount bump phase. But
your question about switch makes me wonder when the URLs are getting
changed during that operation. I *think* it's happening cleanly: each
individual file in a dir gets its URL updated, then the last thing we
do is the dir, but we should check that...

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 15 20:28:49 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.