Re: svn commit: rev 5928 - in trunk/subversion: include libsvn_wc

On Tue, May 13, 2003 at 07:46:39PM -0500, Ben Collins-Sussman wrote:
>...
> > > + else if (! eb->target)
> > > + {
> > > + /* For an update with a NULL target, this is equivalent to open_dir(): */
> >
> > Then these two blocks of code should be factored out.
>
> Aw, don't be silly. We're talking about 2 funtion calls -- just
> fetching the adm_access baton and calling entry_modify. Wouldn't that
> be just a bit of overabstraction? :-)

Maybe a bit :-), but I did have the same recommended change for both blocks
of code. You also have the structure initialization in there, besides the
two function calls. Further, the comment even says "equivalent". I just
figured that it might be nice to refactor in case more comes along later.

*shrug* I'm not fussed either way, so your call.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org