Re: [PATCH] SWIG bindings refactoring (esp. python)

On Tue, May 13, 2003 at 11:36:14PM +0200, Philipp von Weitershausen wrote:
> My goal is to make the SWIG bindings to python as easy to use and as
> pythonic as possible. The following patch is a result of the previous
> discussion with cmpilato and Greg Stein ("eliminate -noproxy flat to SWIG").

+1 on the patch concept and from a simple review. I haven't applied and
tested, however.

-0 on the changes to the SWIG invocation for Java. I'm not sure they are
ready or want the proxies (yet).

In a future change, I'd like to see a swig/python/libsvn/ subdir cuz I'm not
too cozy with the __init__.py addition (but it is fine for now). That would
alter the copying strategy (and I don't think we want to build in the libsvn
subdir, altho I'd be find with building into python/build/).

Otherwise, this looks just great.

> When this patch is applied, all python code should still run unless it
> uses accessor functions. Instead of using accessor functions, you can
> now simply acquire the attribute of your struct wrapping object to
> acquire a struct member (e.g. ctx.auth_baton instead of
> svn_client_ctx_t_auth_baton_get(ctx).).

All the accessor functions are still present in the wrapper, so shouldn't
old code continue to work just fine?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org