[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svn_load_dirs.pl.in is too picky about its libraries

From: Jack Repenning <jrepenning_at_collab.net>
Date: 2003-05-13 22:13:52 CEST

Svn_load_dirs.pl requires fairly new versions of its Perl libraries. In
particular, it wants newer versions than I have on my Red Hat 7.2
system. This patch makes it run on my system, and my tests seem to show
it works just fine.

Some cautions and notes:

Perl Versions: At first, I thought I had a stock RH7.2, but perhaps not.
I didn't set it up. So I'm not guaranteeing that this patch makes the
script run on an out-of-the-box RH7.2.

SVN Versions: All tests done with SVN 0.19.0 (r5240), client and server.

Testing: I'm not sure what-all tests I ought to run on this change. In
particular, one of the delta'ed libraries is the MD5 one; I think it
ends up comparing MD5's from the repo against those it computes locally.
I don't know what are the differences between my version and the one the
script originally required. Conceivably, there's a bug/fix there that
only miscomputes the MD5 on alternate Shrove Tuesdays that happen to
fall on a Thursday, or something like that. Hashes can be tricky. If
so, the overwhelming probability is that it would reimport an identical
copy, which seems relatively innocuous (odds of miscomputing a hash and
having it match the older, different version are the same as those of
properly computing the hash and having it accidently match, which is
commonly taken to be negligible).

What I tested:
- I "svn export"ed the whole SVN tree to plain file space.
- I svn_load_dirs.pl'ed it into a new, empty repo
- I svn_load_dirs.pl'ed it again, and confirmed that nothing new was

Jack Repenning
CollabNet, Inc.
o: 650.228.2562
c: 408.835.8090

* tools/client-side/svn_load_dirs.pl.in
  Downgrade library version requirements (may now match Red Hat 7.2)

Index: tools/client-side/svn_load_dirs.pl.in
--- tools/client-side/svn_load_dirs.pl.in (revision 5918)
+++ tools/client-side/svn_load_dirs.pl.in (working copy)
@@ -10,14 +10,14 @@
 use strict;
 use Carp;
 use Cwd;
-use Digest::MD5 2.20;
+use Digest::MD5 2.13;
 use File::Copy 2.03;
 use File::Find;
 use File::Path 1.0404;
 use File::Temp 0.12 qw(tempdir);
 use Getopt::Long 2.25;
 use Text::Wrap;
-use URI 1.17;
+use URI 1.12;
 $Text::Wrap::columns = 72;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 22:15:14 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.