Re: [PATCH][RESEND] Issue #1295 (take 5)

Mark Grosberg wrote:

>Anybody have a chance to look over my latest patch? Haven't heard anything
>back for several days.
>
>

I remember one relevant comment that you haven't addressed yet (see
attached message).

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/

attached mail follows:

Mark Grosberg <mark@nolab.conman.org> writes:

> I'd really rather not touch Python. I know Perl, but not Python and this
> would take me a considerable amount of time to learn.
>
> > Modifying the commit list in a message passed in with -F should work, right?
>
> I don't know. The code is pretty hard to follow. Not even sure how -F
> works.

Your code should already do this correctly. However, I have another
suggestion:

> @@ -542,8 +671,16 @@
>
> /* Strip the prefix from the buffer. */
> if (message)
> + {
> + char *commited_list = apr_pstrdup (pool, msg2);
> + apr_hash_t *seen = apr_hash_make(pool);
> +
> + process_comitted_list (seen, commited_list, pool);
> + flag_unmarked (lmb, commit_items, seen, pool);
> +
> truncate_buffer_at_prefix (&message->len, message->data,
> EDITOR_EOF_PREFIX);
> + }

Move your process_comitted_list functionality *into* the
truncate_buffer_at_prefix (renaming that function as appropriate, like
handle_commit_paths() or something). Then make the new function do:

  1. Search for the EDITOR_EOF_PREFIX. If not found, return. Else,
      remember the buffer location to "crop" to.
  2. Handle the path list manipulations.
  3. Crop (truncate) the buffer.

No sense in pouring over this buffer twice.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 22:12:11 2003