Re: svn commit: rev 5912 - in trunk/subversion: clients/cmdline libsvn_subr libsvn_wc

Branko Čibej <brane@xbc.nu> writes:
> Nice. Can you do the converse change in svn_path_internal_style? Then we
> might even be able to kill all the checks using SVN_PATH_IS_PLATFORM_EMPTY.

The last thing svn_path_internal_style() does is call
svn_path_canonicalize(), which converts "." to "" :

   /** Return a new path like @a path, but with any trailing
    * separators that don't affect @a path's meaning removed. Will
    * convert a "." path to "". Allocate the new path in @a pool if
    * anything changed, else just return @a path.
    *
    * (At some future point, this may make other semantically
    * inoperative transformations.)
    */

...a promise the code seems to support. Of course, we might be able
to kill a lot of those checks anyway, but changing
svn_path_internal_style() shouldn't affect the question.

I'm glad you asked, though, because (aside from offering an
all-too-rare chance to correct you) it caused me to look more closely
at the path code, resulting in revision 5924.

I'm really done mucking around with path code today :-).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 22:00:58 2003