[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5814 - in trunk/subversion: libsvn_wc tests/clients/cmdline

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-05-13 20:31:41 CEST

Brian Denny <brian@briandenny.net> writes:

> [Some comments on this patch which should make it easier to review:
> "maybe_bump_dir_info" is the place under close_directory where revision
> numbers in the entries file may get updated. My thinking is, if we are
> ready to bump the revnum, then we should also be ready to prune
> missing/deleted directories. So iterate through the entries, removing
> any entry for a missing or deleted directory.]

I'm about to make major changes to update_editor.c.

* add_dir() will immediately add an entry to the parent's entries
  file, and create a new directory containing an entries file with
  only a THIS_DIR entry at update's target-revnum, with an
  'incomplete=true' attribute.

* open_dir() will immediately mark the directory as incomplete, and as
  being at the update's target-revnum

* close_dir() will still call maybe_bump_dir_info()

* maybe_bump_dir_info() will remove the 'incomplete' flag if the dir's
  refcount hits zero (rather than changing the revnum)

Dunno if this has weird affects regarding your patch....?

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 20:34:39 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.