Re: svn commit: rev 5912 - in trunk/subversion: clients/cmdline libsvn_subr libsvn_wc

cmpilato@collab.net writes:
> > Should svn_path_local_style() always convert the incoming UTF8 path to
> > native encoding? I think that would be appropriate for all callers,
> > and it would smallify some code... Thoughts?
>
> Does svn_path_internal_style() do the opposite conversion? I think
> there's benefit to trying to keep these two functions symmetrical.

Good point. It doesn't right now, but it could. Every single caller
of svn_path_internal_style() first converts the path from local
encoding to UTF8 (with the possible exception of one conditional
branch in svn_config__win_config_path, which could be dealt with).

So the functions could still be symmetrical, and take care of our
encoding/decoding needs at the same time they do the style change.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 19:18:41 2003