[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: subversion/libsvn_ra_dav/util.c in release branch

From: <cmpilato_at_collab.net>
Date: 2003-05-13 15:59:58 CEST

Offering a free peer review here. Brane's patch, applied to the
branch with 5888 merged into it, should produce the desired results.

Another way to do this is just to also merge in the 5857 bugfixes, in
which the signature for svn_ra_dav__parsed_request() changed. But
with a minor release coming shortly, I think I'd go without 5857, and
with Brane's patch.

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> With the following patch to libsvn_ra_dav/util.c, both ra_local and
> ra_dav tests pass on Windows. As far as I'm concerned, 0.22.2 is ready
> to roll.
>
>
> Index: subversion/libsvn_ra_dav/util.c
> ===================================================================
> --- subversion/libsvn_ra_dav/util.c (revision 5903)
> +++ subversion/libsvn_ra_dav/util.c (working copy)
> @@ -305,11 +305,6 @@
> ne_xml_push_handler(success_parser, elements,
> validate_cb, startelm_cb, endelm_cb, baton);
>
> - /* if our caller is interested in having access to this parser, call
> - the SET_PARSER callback with BATON. */
> - if (set_parser != NULL)
> - set_parser(success_parser, baton);
> -
> /* create a parser to read the <D:error> response body */
> error_parser = ne_xml_create();
> ne_xml_push_handler(error_parser, error_elements, validate_error_elements,
>
>
>
> --
> Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 13 16:04:24 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.