[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1295 (take 2, with log)

From: <kfogel_at_collab.net>
Date: 2003-05-09 18:03:37 CEST

Greg Stein <gstein@lyra.org> writes:
> Ya know... sometimes I get cranky at the bars that are raised. "Oh, come
> on... give yourself two minutes and you can find the log message!" Of
> course, the counter is: multiply that by the number of patches, and it gets
> bothersome.

Yes, you get cranky too often about this :-).

I wasn't raising any bars. I didn't say "No one will look at your
patch until you repost with a log message", I just explained why it
helped to have it, and asked that he repost with it as that helps
everyone else. That is, letting Mark know (earlier rather than later)
what helps people review patches. Giving advice and shutting someone
out are two completely different things; this was the former.

By the way, the more important counterargument -- which I mentioned in
the mail -- is that even after you find the log message, you can't be
sure how well it still applies to the newly posted patch. That
problem is independent of the number of patches posted.

> But! You've been great, Mark. Thanks for the persistence and the
> understanding. The worst thing we can do is frighten off new contributors
> with an arm's length of rules. It's kind of, "come on! give the guy a
> break... apply his patch already, will ya? iterate after that."

(+1 on the "You've been great, Mark" part!)

The patch was not ready for application -- which is no slur on Mark:
considering that it's his first patch, it was pretty amazing.

But there's no "rules for rules' sake" stuff going on here. All the
requests made of Mark were important for the health of the project.
If they happened to coincide with some of our stated policies, well,
that just means those policies aren't completely random :-).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 18:45:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.