Re: [PATCH] Issue #1295 (take 2, with log)

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> >+/* Parse the edited comitted message and store the named paths
> >+ in the hash. */
> >+static void
> >+process_comitted_list (apr_hash_t *seen,
> >+ char *commited_list,
> >+ apr_pool_t *pool)
> >
>
> The docstring for this function should explain exactly what kind of
> input it expects, what it'll parse and when it'll fail. I'm also a bit
> worried about its silently doing nothing if it encounters something it
> can't parse; I think that's a potential source of many surprises and
> "error" reports; we want to avoid that, so giving a bit of though to the
> failure cases would be good here.

Additionally, I think the spelling "committed" is preferred to a
mixture of "commited" and "commited". :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 09:56:55 2003