[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Issue #1295 (take 2, with log)

From: Sander Striker <striker_at_apache.org>
Date: 2003-05-09 09:51:51 CEST

> From: Mark Grosberg [mailto:mark@nolab.conman.org]
> Sent: Friday, May 09, 2003 9:46 AM

> > The docstring for this function should explain exactly what kind of
> > input it expects, what it'll parse and when it'll fail. I'm also a bit
> > worried about its silently doing nothing if it encounters something it
> > can't parse; I think that's a potential source of many surprises and
> If it gets something it can't parse, it aborts and whatever was parsed is
> checked in. I figured that's what people would want.

No way. I don't want part of my changes to be checked in and part left
hanging in my working copy. That might break the tree, and worse, my
change is suddenly N commits instead of 1.
> I can certainly make it return an integer of success/failure on parsing
> and abort the checkin if there is an error.

That seems like a much better idea.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 09:52:38 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.