[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [rfc/patch] Fix issue 734, import should 'mkdir -p'

From: David Kimdon <dwhedon_at_debian.org>
Date: 2003-05-09 07:10:06 CEST

On Tue, May 06, 2003 at 11:41:29PM -0500, cmpilato@collab.net wrote:
> Jani Averbach <jaa@verso.st.jyu.fi> writes:
> > On 6 May 2003 cmpilato@collab.net wrote:
> >
> > > Am I alone in thinking that it's ridiculous that import takes 3
> > > arguments at all?
> >
> > Not. =) You could count at least me and Peter Davis in the same wagon:
> >
> > http://subversion.tigris.org/issues/show_bug.cgi?id=933
> Oh, well, there you have it.

Sure, so how best to proceed? The two fixes are intertwined, but
distinct. It is looking like 933 will make larger changes than 734
and may also remove the very function that 734 touches. 933 is
unassigned, I might take it on myself, since I'm in a bug fixing mood.

> > > I mean, in my ideal world, import would look like:
> > >
> > > svn import DESTINATION SOURCE [...]
> > >
> > > If destination didn't exist, it and all the intermediate directories
> > > needed would be created. If there were multiple SOURCE(s), then
> > > DESTINATION would be created as a directory, and each of the sources
> > > added to it by their basenames.
> >
> > The issue suggested that source is optional, but I like it to be
> > mandatory. It is too easy otherwise to import something that wasn't your
> > intention.
> I agree with this. I'd prefer SOURCE to be required.

In the last message to issue #933 Karl summarizes a thread [1] that
indicates the new syntax should be :

svn import [SRC] DST_URL

Note that in addition to removing new_repos_entry, source and url are
reversed. That makes import's syntax more like 'svn cp'. 'import'
will be a special case of 'svn cp'. The new syntax will be similar to
traditional UNIX cp, mv, rsync and cvs import syntax. Multiple
sources will not be supported (at least not yet). SRC is optional, in
which case '.' is implied.

Any objections, suggestions, questions?


[1] : I don't mean to start a discussion on the topic unless someone
has something to add in addition to the good discussion that starts


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 07:12:22 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.