Re: [PATCH] Issue #1295

On Fri, 9 May 2003, [UTF-8] Branko Čibej wrote:

> Every function, even static functions, have comments explaingin what
> they do, and the use of the parameters, at the beginning. Look at the
> existing code, you're bound to find some.

You mean just the one-liner. I was expecting something more Java-Doc like.

I'll add this then.

> >>it strikes me that you're complicating things enormously, *and* you
> >>introduced a quadratic algorithm for tagging the array.
> >>
> >>
> >
> >Why?
> >
> Why what? :-)

Why use a hash.

Now, what do I do if I can't allocate memory for the hash table. Will
apr_hash_make() ever return NULL? If so, what do I do. I will have to
throw an svn_erorr_t. How do I make one?

> And using the phrase "usually the list isn't that large" as an argument
> _for_ a quadratic algorithm makes my hair stand on end. I've heard it so
> many times...

Ok. I was being lazy. I'll do it right...

L8r,
Mark G.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 02:43:12 2003