[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5790 - trunk/subversion/libsvn_wc

From: <cmpilato_at_collab.net>
Date: 2003-05-05 19:29:30 CEST

kfogel@collab.net writes:

> brane@xbc.nu writes:
> > It's also impossible to test ATM, for two reasons: a) the Windows
> > build doesn't, which means that nobody's running tests on Windows;
> > b) our test coverage isn't good enough.
> >
> > One thing I never saw was performance test output pointing its
> > finger of blame at that chmod. Has anyone seen any difference in the
> > speed of the client? If not, then I can't understand why you're
> > wasting time on this, breaking things left and right, without a
> > single bit of hard data to go on.
> "Left and right" is a bit much :-). I did run the test suite on
> Unix; I wasn't aware that Windows had different semantics
> w.r.t. file removal & perms than Unix has.

Actually, that aspect was a surprise to me as well.

> My primary motivation wasn't for performance reasons, it was because
> I felt that our underlying (svn_io_) file removal mechanism
> shouldn't be doing a chmod by default, because that might someday
> blow away something that shouldn't be blown away. Instead, it
> should be the caller's responsibility to know that something is
> ready to be removed.

FWIW, I agree. Our working copy library is plenty complex, but
shouldn't be so much that it can't keep track of the permissions of
the files it exists to manage. And svn_io_remove_file most certainly
should not be just blanketly ensuring that it can perform the
requested removal.

The 'force' flag idea is, in my opinion, a crutch for sloppy coding.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 5 19:30:20 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.