On Sunday, May 4, 2003, at 06:32 PM, Philip Martin wrote:
> rooneg@tigris.org writes:
>
>> Author: rooneg
>> Date: Sun May 4 16:51:12 2003
>> New Revision: 5800
>>
>> Modified:
>> trunk/subversion/libsvn_client/cat.c
>> Log:
>> Complete issue 399 by making 'svn cat' expand keywords.
>>
>> * subversion/libsvn_client/cat.c
>> (date_prop_to_human): new helper function for formatting date
>> strings for
>> output.
>> (build_keyword_struct): new helper function for filling in a
>> keywords
>> structure.
>
> Yuk! These functions have code that looks like subr/translate.c, do
> we really need this code twice? If so then we need some regression
> tests to ensure that the two versions don't diverge.
yeah, i'm moving some of them out into a common helper function now (at
least the part for formatting the date), since this code is also needed
in libsvn_client/export.c (right now we get the keyword expansion wrong
there).
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 5 00:35:14 2003