[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5796 - trunk/tools/client-side

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-05-04 23:08:20 CEST

On Sunday, May 4, 2003, at 04:32 PM, Kalle Olavi Niemitalo wrote:

> rooneg@tigris.org writes:
>
>> +;;; Maybe we want more info in mode-line-string. Status of props?
>> Status
>> +;;; compared to what's in the repository (svn st -u) ?
>
> The current code (both yours and the default) already shows the
> file as modified if the properties have changed. It probably
> wouldn't be very useful to display separate statuses for data and
> properties. If the user sees the modification flag and doesn't
> know why it's there, C-x v = will explain it.

I was thinking it might be nice to have separate displays because
that's what we already do for 'svn status'. I'm not really attatched
to the idea.

> I don't think svn status -u should be run automatically, because
> it accesses the network.

yeah, you're probably right.

>> +Compared to the default implementation, this does two things:
>> +Handle the case of a file which has been added, but not committed,
>> +and show the user when their local copy has been modified."
>
> The default implementation already shows whether the working
> copy has been modified: it returns things like "SVN-115" for
> unmodified and "SVN:115" for modified files. This behavior is
> documented at (emacs) VC Mode Line; please reinstate it.

Ahh, now I see. This is where my lack of emacs knowledge comes back to
bite me ;-)

> I don't have an opinion on whether to display "SVN:A" or "SVN:0".

I'll put it back the way it was.

> Wacky idea: Put help-echo properties in the string!
> Something like:
>
> (setq vc-mode #(" SVN-115"
> 1 4 (help-echo "Subversion")
> 4 5 (help-echo "Working copy is unmodified")
> 5 8 (help-echo "Revision 115")))
>
> One could put a mouse menu there as well, but I don't know what
> that should contain.

That sounds cool, but I'll leave it to those with more emacs-fu than
myself to implement.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 4 23:09:09 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.