[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5793 - trunk/tools/client-side

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-05-04 16:08:50 CEST

On Sunday, May 4, 2003, at 09:07 AM, Kalle Olavi Niemitalo wrote:

> rooneg@tigris.org writes:
>> +(defun vc-svn-find-version (file rev buffer)
>> + (apply 'vc-do-command buffer 0 vc-svn-program-name file
>> + "cat" (list "-r" rev)))
> That can be simplified to:
> (defun vc-svn-find-version (file rev buffer)
> (vc-do-command buffer 0 vc-svn-program-name file
> "cat" "-r" rev))
> which is consistent with the rest of vc-svn.el.

that makes sense, i'll change it now. my version was based on
vc-cvs.el, which is where the apply came from, but if we can do without
it (and be more consistent) i'm all for it. honestly, my lisp-fu is
quite minimal, so while i suspected something like that would be
possible, i wasn't sure.

thanks for the review.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 4 16:09:38 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.