[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5768 - in trunk/subversion: libsvn_ra_dav mod_dav_svn tests/clients/cmdline

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-04-30 15:14:53 CEST

Greg Stein <gstein@lyra.org> writes:

> On Tue, Apr 29, 2003 at 04:56:21PM -0500, sussman@tigris.org wrote:
> >...
> > +++ trunk/subversion/mod_dav_svn/update.c Tue Apr 29 16:56:17 2003
> >...
> > + /* split up the 1st public URL. */
> > + serr = dav_svn_simple_parse_uri(&this_info, resource,
> > + child->first_cdata.first->text,
> > + resource->pool);
> > + if (serr != NULL)
> > + {
> > + return dav_svn_convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
> > + "Could not parse src-path URL.");
> > + }
> > + src_path = apr_pstrdup(resource->pool, this_info.repos_path);
>
> That dup seems unnecessary. Didn't you just parse it into resource->pool to
> begin with?

Hm, yeah. This whole block is just a copy-and-paste of what we do for
<dst-path>. I'll fix them both.

> Looks great, otherwise! I assume this fixes the issue. Do we want to leave
> that open to remember to clean up the code?

I'll close the issue, then open a low-priority 1.0 task to remove
support for old-style update-reports. We're in no rush to remove that
support, since nothing is blocking on it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 30 15:16:41 2003

This is an archived mail posted to the Subversion Dev mailing list.