Re: svn commit: rev 5677 - in trunk/subversion: include libsvn_wc

Greg Stein <gstein@lyra.org> writes:
> In most of these functions, 'associated' can be NULL, right? For example,
> the first time you grab an access baton.

In the _open functions, associated can be NULL, because that just
means you don't want to associate the new baton with an existing set.

In the _try functions, it can be NULL, but if it's not, it's still
okay if the set does not have the requested baton -- just _open it and
add it to the set.

> So... I'm a bit unclear on whether a problem truly exists, but it doesn't
> feel quite right. Certainly, the expectation of being able to pass NULL to
> some of these functions for the "associated" set is not very clear. Which
> allow it, and which don't. (it looks like the retrieve functions will crash
> if you pass NULL)

They should crash, yes; and they are the only ones that should.

I'll have to look at this in more detail, to tell whether it's just a
doc problem or an actual code problem. (Did the clarification above
change anything for you? That would indicate a doc problem...)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 29 01:41:40 2003