RE: svn commit: rev 5717 - trunk/subversion/libsvn_client

> From: sussman@collab.net [mailto:sussman@collab.net]
> Sent: Thursday, April 24, 2003 2:39 PM

[...]
> > - svn_subst_keywords_t *final_kw = apr_pcalloc (pool, sizeof(*final_kw));
> > + svn_subst_keywords_t final_kw;
> >
> > if (fb->eol_style_val)
> > svn_subst_eol_style_from_value (&style, &eol, fb->eol_style_val->data);
> >
> > if (fb->keywords_val)
> > - build_final_keyword_struct (fb, final_kw, pool);
> > + build_final_keyword_struct (fb, &final_kw, pool);
>
>
> Does this really work? The helper function assumes that final_kw has
> had all its fields initialized to NULL.

Then do:

  svn_subst_keywords_t final_kw = { 0 };

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 24 14:44:59 2003