[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5714 - trunk/subversion/libsvn_client

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-04-24 01:29:50 CEST

On Wednesday, April 23, 2003, at 04:47 PM, sussman@tigris.org wrote:

> Author: sussman
> Date: Wed Apr 23 15:47:48 2003
> New Revision: 5714
>
> Modified:
> trunk/subversion/libsvn_client/client.h
> trunk/subversion/libsvn_client/export.c
> Log:
> Work on issue #1230: a dedicated 'svn export' editor.
>
> This change adds keyword-expansion support to the export editor, but
> it isn't working properly yet. Can someone enable the export editor
> and take a look at the problem? I'm mystified here.
>
> [ If a file has the svn:keywords property, it's being created as a
> 0-byte file for some unexplainable reason. If you comment out the
> registration of change_file_prop in svn_client__get_export_editor,
> the problem goes away. And in gdb, it seems that the tmpfile is
> *already* 0 bytes right before we call svn_subst_copy_and_translate!
> ]

i think that happens in the non-keyword case as well...

the data hasn't gotten flushed out to disk yet (that'll happen when the
pool cleanups for it are run, but that hasn't happened yet). in the !
eol_style && ! keywords case, you're doing an svn_io_file_rename, which
calls rename(2) under the covers, and later when the data is flushed
out via the cleanup handler, it still gets where we want it. when you
call svn_subst_copy_and_translate, it's not finding anything to
translate because it opens the file before any data has been written to
it.

of course, i can't see the right way to fix this at the moment, but
from my fumbling around in gdb it seems to be what's happening, and if
i turn off buffering in svn_io_open_unique_file, everything works just
fine.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 24 01:30:35 2003

This is an archived mail posted to the Subversion Dev mailing list.