[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5686 - trunk/subversion/tests/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-04-23 22:50:15 CEST

sussman@tigris.org wrote:

>Author: sussman
>Date: Mon Apr 21 14:33:14 2003
>New Revision: 5686
> trunk/subversion/tests/clients/cmdline/diff_tests.py
>* diff_tests.py (diff_base_to_repos): vastly expand this test's coverage.
>Modified: trunk/subversion/tests/clients/cmdline/diff_tests.py
>--- trunk/subversion/tests/clients/cmdline/diff_tests.py (original)
>+++ trunk/subversion/tests/clients/cmdline/diff_tests.py Mon Apr 21 14:33:14 2003
>@@ -853,7 +853,7 @@
> #----------------------------------------------------------------------
> # Regression test for issue #977: make 'svn diff -r BASE:N' compare a
> # repository tree against the wc's text-bases, rather than the wc's
>-# working files.
>+# working files. This is a long test, which checks many variations.

It's never a good idea to burden a single test case with too much work.
There are two problems here:

    * An early (sub)test might fail, causing all others to be skipped,
      whether or not they would faile themselves.
    * It's much harder to reproduce any errors if they happen after 50
      different commands have been run

I know we do similar things elsewhere, but for new cases, it's generally
a better idea to add whole new tests.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 23 22:51:06 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.