[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch review for the DAV-savvy

From: <cmpilato_at_collab.net>
Date: 2003-04-22 23:54:38 CEST

Justin Erenkrantz <justin@erenkrantz.com> writes:

> --On Tuesday, April 22, 2003 11:58:25 -0500 cmpilato@collab.net wrote:
>
> > I'd appreciate it if anyone who is familiar with DAV and mod_dav_svn
> > would review the small patch I posted to issue #1251. Below is a link
> > to the issue for your convenience. Thanks.
> >
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1251
>
> The patch is correct, but wouldn't it be better only to issue weak
> entity tags on those HTML/XML index pages rather than the files? A
> collection would get a weak entity tag, but not the files in a
> collection. I believe mod_dav_svn should have enough knowledge to
> make this distinction. We should always strive to use strong entity
> tags. Weak entity tags enter a world of confusion where no one can
> agree how they should be interpreted. -- justin

Ah, that makes sense to me. Perhaps the dav_svn_getetag() function
could check to see if the resource is a collection or not?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 22 23:58:47 2003

This is an archived mail posted to the Subversion Dev mailing list.