[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5687 - in trunk/subversion: libsvn_client libsvn_wc tests/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2003-04-22 03:06:04 CEST

Philip Martin <philip@codematters.co.uk> writes:
> > What I'm worried about is the case where the baton was retrieved from
> > the associated set. We don't want to close it in that case, I think,
> > we just want to leave it where we found it. But if we got it via
> > _open(), then we could close it.
> Agreed.
> > Is it worth adding a boolean and a check at the end of the code? I
> > decided to just depend on the pool eventually being cleared, but now
> > that you mention it, the code could fail if multiple entities are
> > added in that parent directory.
> Yes, that's the sort of thing that caught me in the past.
> > Should the baton be unconditionally added to the associated set? That
> > seems like an unwise side effect of the parent-updating code...
> I don't think adding it will work, and so the boolean is required.

No problem, I'll do it -- thanks for noticing & for the headwork, as


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 22 03:51:26 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.