[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] : fix for psvn.el svn-status-mode

From: <kfogel_at_collab.net>
Date: 2003-04-21 17:11:44 CEST

David Kimdon <dwhedon@debian.org> writes:
> I received a bug report with a patch in the Debian bug tracking
> system[1]. I'm not qualified to evaluate this patch (don't use emacs
> or know much lisp). Can anyone evaluate this patch?

Thanks for forwarding the bug report. I committed a slightly
different fix, see revision 5683.

-Karl

> * tools/client-side/psvn/psvn.el (svn-status-mode) : Make status
> buffer read-only directly, instead of going through toggle-read-only
> which would enable View mode depending on . Patch thanks to
> Kalle Olavi Niemitalo <kon@iki.fi>.
>
> Index: tools/client-side/psvn/psvn.el
> ===================================================================
> --- tools/client-side/psvn/psvn.el (revision 5680)
> +++ tools/client-side/psvn/psvn.el (working copy)
> @@ -507,7 +507,7 @@
> (setq major-mode 'svn-status-mode)
> (setq mode-name "svn-status")
> (setq mode-line-process 'svn-status-mode-line-process)
> - (toggle-read-only 1))
> + (setq buffer-read-only t))
>
> (defun svn-status-update-mode-line ()
> (setq svn-status-mode-line-process
>
>
> [1] : I have included Kalle's description of the problem and the proposed
> solution here. The full bug report can be found at :
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=188706
>
> Kalle's words:
>
> I have enabled view-read-only in Emacs, so that visiting a
> read-only file automatically puts it in View mode. Now, when I
> use M-x svn-status, the *svn-status* buffer enters View mode too.
> Pressing m in the buffer then runs the View mode command
> point-to-register, rather than the svn-status mode command
> svn-status-set-user-mark.
>
> This is quite easy to fix. At the end of svn-status-mode in
> psvn.el, there is the form:
>
> (toggle-read-only 1)
>
> Change it to:
>
> (setq buffer-read-only t)
>
> This way, it makes the buffer read-only directly, instead of
> going through toggle-read-only which would enable View mode.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 21 17:57:03 2003

This is an archived mail posted to the Subversion Dev mailing list.