Re: svn commit: rev 5627 - trunk/subversion/libsvn_diff

Karl Fogel wrote:

>striker@tigris.org writes:
>
>
>>Log:
>>Fix the failures we've been seeing on HP-UX due to over aggressive
>>mmap'ing. This fix is greatly inspired by Branko Cibej.
>>
>>* subversion/libsvn_diff/diff_file.c
>>
>> (map_or_read_file): New helper function (with accompagnying macros).
>>
>> (svn_diff__file_datasource_open, svn_diff_file_output_merge): Call
>> map_or_read_file instead of implementing same logic in both functions.
>>
>>
>
>Awesome!
>
>Does this fix http://subversion.tigris.org/issues/show_bug.cgi?id=688 ?
>
>

Not by far. It should stop the diff-diff3 tests failing on HP-UX,
though. Issue 688 is deeper, and to solve it we (I) have to implement a
cache of open databases in the FS layer.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org