[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_svn failure over ssh on release branch.

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-04-15 20:10:30 CEST

On Tue, 2003-04-15 at 13:31, Philip Martin wrote:
> Now when we get the tmpfile1 contents (step 4) they are not
> immediately flushed to disk, that doesn't happen until the close.
> Before that happens we open the second RA session (step 5), which
> calls apr_proc_create to start the ssh process. This involves a
> fork/exec and the child process appears to flush it's copy of
> tmpfile1, probably in a pool cleanup handler. Then the parent process
> closes tmpfile1 (step 7) flushing the parents version of the file.
> The result is that tmpfile1 gets the buffered data twice.

Oh, right, of course.

I have reported this as a bug in APR in the past (child cleanup handlers
for files should not flush buffers), but it hasn't generated much
interest there. Your patch looks good as a workaround on the svn side.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 15 20:18:57 2003

This is an archived mail posted to the Subversion Dev mailing list.